Code review

A rushed code review lets through exactly what costs the most to fix later: an uncovered edge case, a quiet security flaw or a confusing name someone will have to decipher six months from now. Reviewing well is not approving fast, it is protecting whoever comes next to touch that same file.

This template breaks a pull request review into concrete steps so none of them slips past you when several changes are waiting. The point is not to slow things down, it is to walk the same points every time so quality does not depend on the kind of day you are having or on how urgently the author needs it merged.

What to check on every pull request

These are the points the template brings, meant to read the change from the outside in:

• Understand the goal of the change before reading a single line
• Check that the logic is correct and does what it promises
• Review the error handling so exceptions are not swallowed in silence
• Look for uncovered edge cases, like empty lists or null values
• Verify there are enough tests for what the change touches
• Review naming and readability so it reads without explanations
• Spot duplicated code worth pulling out
• Assess the performance impact on the hottest paths
• Review possible security flaws in inputs and permissions
• Leave clear and useful comments, not just point out what is wrong

How it works in Foco

When you import it, Foco creates the "Review" workspace with these points in the List view, so you walk them in order on each pull request and tick each one as you verify it. Since the review repeats on every change, you can set it to recur and get a fresh list each time.

If you share reviews with someone else, you assign each point to whoever checks it, mark as important anything that cannot go unreviewed and drop a quick voice note about something you want to discuss without leaving the task.